luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-26 15:36:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[gobject] set all properties before constructed()"

Browse Source 
This reverts commit 028d4a03f2.

I thought that we would be able to get away with this incompatible
change but it appears to impact far too much existing code.  The only
thing we can do is revert.

https://bugzilla.gnome.org/show_bug.cgi?id=688596
This commit is contained in:
Ryan Lortie 2012-11-19 10:28:55 -05:00
parent 39150f90e5
commit 5272bc4d67
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gobject/gobject.c
View File

@ -1741,15 +1741,15 @@ g_object_newv (GType object_type,
g_object_notify_queue_thaw (object, nqueue); g_object_notify_queue_thaw (object, nqueue);
} }
/* run 'constructed' handler if there is a custom one */
if (newly_constructed && CLASS_HAS_CUSTOM_CONSTRUCTED (class))
class->constructed (object);
/* set remaining properties */ /* set remaining properties */
for (i = 0; i < n_oparams; i++) for (i = 0; i < n_oparams; i++)
object_set_property (object, oparams[i].pspec, oparams[i].value, nqueue); object_set_property (object, oparams[i].pspec, oparams[i].value, nqueue);
g_free (oparams); g_free (oparams);
/* run 'constructed' handler if there is a custom one */
if (newly_constructed && CLASS_HAS_CUSTOM_CONSTRUCTED (class))
class->constructed (object);
if (CLASS_HAS_PROPS (class)) if (CLASS_HAS_PROPS (class))
{ {
/* release our own freeze count and handle notifications */ /* release our own freeze count and handle notifications */