*giowin32.c: g_source_remove()ing an socket iochannel closes

the socket when it should not. Patch by Peter Zelezny
<zed@linux.com>
*giowin32.c: Fix a few typos
This commit is contained in:
Andy Lanoix 2001-07-02 23:57:19 +00:00
parent 7d676fb206
commit 527a422493
9 changed files with 67 additions and 7 deletions

View File

@ -1,3 +1,11 @@
Mon Jul 2 19:48:52 2001 Andrew Lanoix <alanoix@umich.edu>
*giowin32.c: g_source_remove()ing an socket iochannel closes
the socket when it should not. Patch by Peter Zelezny
<zed@linux.com>
*giowin32.c: Fix a few typos
Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com> Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com>
* glib/giochannel.c (g_io_channel_get_buffer_condition): Fix. * glib/giochannel.c (g_io_channel_get_buffer_condition): Fix.

View File

@ -1,3 +1,11 @@
Mon Jul 2 19:48:52 2001 Andrew Lanoix <alanoix@umich.edu>
*giowin32.c: g_source_remove()ing an socket iochannel closes
the socket when it should not. Patch by Peter Zelezny
<zed@linux.com>
*giowin32.c: Fix a few typos
Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com> Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com>
* glib/giochannel.c (g_io_channel_get_buffer_condition): Fix. * glib/giochannel.c (g_io_channel_get_buffer_condition): Fix.

View File

@ -1,3 +1,11 @@
Mon Jul 2 19:48:52 2001 Andrew Lanoix <alanoix@umich.edu>
*giowin32.c: g_source_remove()ing an socket iochannel closes
the socket when it should not. Patch by Peter Zelezny
<zed@linux.com>
*giowin32.c: Fix a few typos
Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com> Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com>
* glib/giochannel.c (g_io_channel_get_buffer_condition): Fix. * glib/giochannel.c (g_io_channel_get_buffer_condition): Fix.

View File

@ -1,3 +1,11 @@
Mon Jul 2 19:48:52 2001 Andrew Lanoix <alanoix@umich.edu>
*giowin32.c: g_source_remove()ing an socket iochannel closes
the socket when it should not. Patch by Peter Zelezny
<zed@linux.com>
*giowin32.c: Fix a few typos
Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com> Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com>
* glib/giochannel.c (g_io_channel_get_buffer_condition): Fix. * glib/giochannel.c (g_io_channel_get_buffer_condition): Fix.

View File

@ -1,3 +1,11 @@
Mon Jul 2 19:48:52 2001 Andrew Lanoix <alanoix@umich.edu>
*giowin32.c: g_source_remove()ing an socket iochannel closes
the socket when it should not. Patch by Peter Zelezny
<zed@linux.com>
*giowin32.c: Fix a few typos
Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com> Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com>
* glib/giochannel.c (g_io_channel_get_buffer_condition): Fix. * glib/giochannel.c (g_io_channel_get_buffer_condition): Fix.

View File

@ -1,3 +1,11 @@
Mon Jul 2 19:48:52 2001 Andrew Lanoix <alanoix@umich.edu>
*giowin32.c: g_source_remove()ing an socket iochannel closes
the socket when it should not. Patch by Peter Zelezny
<zed@linux.com>
*giowin32.c: Fix a few typos
Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com> Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com>
* glib/giochannel.c (g_io_channel_get_buffer_condition): Fix. * glib/giochannel.c (g_io_channel_get_buffer_condition): Fix.

View File

@ -1,3 +1,11 @@
Mon Jul 2 19:48:52 2001 Andrew Lanoix <alanoix@umich.edu>
*giowin32.c: g_source_remove()ing an socket iochannel closes
the socket when it should not. Patch by Peter Zelezny
<zed@linux.com>
*giowin32.c: Fix a few typos
Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com> Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com>
* glib/giochannel.c (g_io_channel_get_buffer_condition): Fix. * glib/giochannel.c (g_io_channel_get_buffer_condition): Fix.

View File

@ -1,3 +1,11 @@
Mon Jul 2 19:48:52 2001 Andrew Lanoix <alanoix@umich.edu>
*giowin32.c: g_source_remove()ing an socket iochannel closes
the socket when it should not. Patch by Peter Zelezny
<zed@linux.com>
*giowin32.c: Fix a few typos
Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com> Mon Jul 2 16:03:21 2001 Owen Taylor <otaylor@redhat.com>
* glib/giochannel.c (g_io_channel_get_buffer_condition): Fix. * glib/giochannel.c (g_io_channel_get_buffer_condition): Fix.

View File

@ -170,7 +170,6 @@ static unsigned __stdcall
read_thread (void *parameter) read_thread (void *parameter)
{ {
GIOWin32Channel *channel = parameter; GIOWin32Channel *channel = parameter;
GSList *tmp;
guchar *buffer; guchar *buffer;
guint nbytes; guint nbytes;
@ -464,10 +463,7 @@ select_thread (void *parameter)
LOCK (channel->mutex); LOCK (channel->mutex);
if (channel->fd != -1) if (channel->fd != -1)
{ {
if (channel->debug) /* DO NOT close the fd here */
g_print ("select_thread %#x: channel fd %d needs closing\n",
channel->thread_id, channel->fd);
closesocket (channel->fd);
channel->fd = -1; channel->fd = -1;
} }
@ -691,7 +687,7 @@ g_io_win32_msg_write (GIOChannel *channel,
memmove (&msg, buf, sizeof (MSG)); memmove (&msg, buf, sizeof (MSG));
if (!PostMessage (win32_channel->hwnd, msg.message, msg.wParam, msg.lParam)) if (!PostMessage (win32_channel->hwnd, msg.message, msg.wParam, msg.lParam))
{ {
g_set_error(err, G_IO_CHANNEL_ERROR, G_IO_CHANNEL_ERROR_FAILED g_set_error(err, G_IO_CHANNEL_ERROR, G_IO_CHANNEL_ERROR_FAILED,
_("Unknown error")); /* Correct error message? FIXME */ _("Unknown error")); /* Correct error message? FIXME */
return G_IO_STATUS_ERROR; return G_IO_STATUS_ERROR;
} }
@ -707,7 +703,7 @@ g_io_win32_no_seek (GIOChannel *channel,
GSeekType type, GSeekType type,
GError **err) GError **err)
{ {
g_set_error(error, G_IO_CHANNEL_ERROR, G_IO_CHANNEL_ERROR_SPIPE, g_set_error(err, G_IO_CHANNEL_ERROR, G_IO_CHANNEL_ERROR_SPIPE,
_("Seeking not allowed on this type of channel")); _("Seeking not allowed on this type of channel"));
return G_IO_STATUS_ERROR; return G_IO_STATUS_ERROR;