From 56e25d81f6b5727c264ee9b100a77c6dc18d5ae6 Mon Sep 17 00:00:00 2001 From: Emmanuel Fleury Date: Tue, 17 Nov 2020 23:56:30 +0100 Subject: [PATCH] Fix several signedness warnings in gio/tests/converter-stream.c:g_compressor_converter_convert() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gio/tests/converter-stream.c: In function ‘g_compressor_converter_convert’: gio/tests/converter-stream.c:234:23: error: comparison of integer expressions of different signedness: ‘long int’ and ‘gsize’ {aka ‘long unsigned int’} 234 | if (in_end - in < block_size) | ^ gio/tests/converter-stream.c:244:21: error: comparison of integer expressions of different signedness: ‘int’ and ‘gsize’ {aka ‘long unsigned int’} 244 | for (i = 0; i < block_size; i++) | ^ gio/tests/converter-stream.c:257:33: error: comparison of integer expressions of different signedness: ‘long int’ and ‘gsize’ {aka ‘long unsigned int’} 257 | if (v == 0 && in_end - in == block_size && (flags & G_CONVERTER_INPUT_AT_END) == 0) | ^~ --- gio/tests/converter-stream.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gio/tests/converter-stream.c b/gio/tests/converter-stream.c index 2c2a4ed01..254fe8a22 100644 --- a/gio/tests/converter-stream.c +++ b/gio/tests/converter-stream.c @@ -210,7 +210,7 @@ g_compressor_converter_convert (GConverter *converter, { const guint8 *in, *in_end; guint8 v, *out; - int i; + gsize i; gsize block_size; in = inbuf; @@ -231,7 +231,7 @@ g_compressor_converter_convert (GConverter *converter, block_size = v * 1000; /* Not enough data */ - if (in_end - in < block_size) + if ((gsize) (in_end - in) < block_size) { if (*bytes_read > 0) break; @@ -254,7 +254,7 @@ g_compressor_converter_convert (GConverter *converter, } } - if (v == 0 && in_end - in == block_size && (flags & G_CONVERTER_INPUT_AT_END) == 0) + if (v == 0 && (gsize) (in_end - in) == block_size && (flags & G_CONVERTER_INPUT_AT_END) == 0) { if (*bytes_read > 0) break;