luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-04 18:26:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

gkeyfile: Clear a variable after freeing it

Browse Source 
find_file_in_data_dirs() doesn’t actually clear output_path to NULL on
failure, so this prevents a use-after-free on that (fd == -1) error
path.

Spotted by Coverity (CID: #1352981).
This commit is contained in:
Philip Withnall 2016-03-21 12:35:25 +00:00
parent 7401dc1b0c
commit 58f56b2460
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
glib/gkeyfile.c
View File

@ -970,6 +970,7 @@ g_key_file_load_from_dirs (GKeyFile *key_file,
while (*data_dirs != NULL && !found_file) while (*data_dirs != NULL && !found_file)
{ {
g_free (output_path); g_free (output_path);
output_path = NULL;
fd = find_file_in_data_dirs (file, data_dirs, &output_path, fd = find_file_in_data_dirs (file, data_dirs, &output_path,
&key_file_error); &key_file_error);