luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-29 08:56:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixing signedness problem in glib/gstrfuncs.c

Browse Source 
glib/gstrfuncs.c: In function ‘g_strstr_len’:
glib/gstrfuncs.c:2709:24: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare]
       if (haystack_len < needle_len)
                        ^
This commit is contained in:
Emmanuel Fleury 2019-02-04 09:49:35 +01:00
parent 81a4698c45
commit 592d4369d4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
glib/gstrfuncs.c
View File

@ -2700,13 +2700,14 @@ g_strstr_len (const gchar *haystack,
{ {
const gchar *p = haystack; const gchar *p = haystack;
gsize needle_len = strlen (needle); gsize needle_len = strlen (needle);
gsize haystack_len_unsigned = haystack_len;
const gchar *end; const gchar *end;
gsize i; gsize i;
if (needle_len == 0) if (needle_len == 0)
return (gchar *)haystack; return (gchar *)haystack;
if (haystack_len < needle_len) if (haystack_len_unsigned < needle_len)
return NULL; return NULL;
end = haystack + haystack_len - needle_len; end = haystack + haystack_len - needle_len;