luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-04-01 21:33:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

ghash: Document that g_hash_get_[keys|values]() are expensive

Browse Source 
And definitely not the right way to iterate over a hash table (as seen
in code in the wild).

https://bugzilla.gnome.org/show_bug.cgi?id=741779
This commit is contained in:
Philip Withnall 2014-12-19 18:52:32 +00:00
parent c639b628ec
commit 59748c3be0
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
glib/ghash.c
View File

@ -1701,6 +1701,10 @@ g_hash_table_size (GHashTable *hash_table)
* Retrieves every key inside @hash_table. The returned data is valid * Retrieves every key inside @hash_table. The returned data is valid
* until changes to the hash release those keys. * until changes to the hash release those keys.
* *
* This iterates over every entry in the hash table to build its return value.
* To iterate over the entries in a #GHashTable more efficiently, use a
* #GHashTableIter.
*
* Returns: a #GList containing all the keys inside the hash * Returns: a #GList containing all the keys inside the hash
* table. The content of the list is owned by the hash table and * table. The content of the list is owned by the hash table and
* should not be modified or freed. Use g_list_free() when done * should not be modified or freed. Use g_list_free() when done
@ -1740,6 +1744,10 @@ g_hash_table_get_keys (GHashTable *hash_table)
* Note: in the common case of a string-keyed #GHashTable, the return * Note: in the common case of a string-keyed #GHashTable, the return
* value of this function can be conveniently cast to (const gchar **). * value of this function can be conveniently cast to (const gchar **).
* *
* This iterates over every entry in the hash table to build its return value.
* To iterate over the entries in a #GHashTable more efficiently, use a
* #GHashTableIter.
*
* You should always free the return result with g_free(). In the * You should always free the return result with g_free(). In the
* above-mentioned case of a string-keyed hash table, it may be * above-mentioned case of a string-keyed hash table, it may be
* appropriate to use g_strfreev() if you call g_hash_table_steal_all() * appropriate to use g_strfreev() if you call g_hash_table_steal_all()
@ -1779,6 +1787,10 @@ g_hash_table_get_keys_as_array (GHashTable *hash_table,
* Retrieves every value inside @hash_table. The returned data * Retrieves every value inside @hash_table. The returned data
* is valid until @hash_table is modified. * is valid until @hash_table is modified.
* *
* This iterates over every entry in the hash table to build its return value.
* To iterate over the entries in a #GHashTable more efficiently, use a
* #GHashTableIter.
*
* Returns: a #GList containing all the values inside the hash * Returns: a #GList containing all the values inside the hash
* table. The content of the list is owned by the hash table and * table. The content of the list is owned by the hash table and
* should not be modified or freed. Use g_list_free() when done * should not be modified or freed. Use g_list_free() when done