luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-08-25 10:28:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

gfile: make_directory_with_parents race condition

Browse Source 
A race condition could cause g_file_make_directory_with_parents() to
fail with G_IO_ERROR_EXISTS despite the requested directory not
existing.

https://bugzilla.gnome.org/show_bug.cgi?id=719455
This commit is contained in:
Philip Chimento
2013-11-27 17:43:18 -08:00
committed by Ryan Lortie
parent 388e0d576f
commit 5a7db3015a
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gio/gfile.c
View File

@@ -3777,6 +3777,11 @@ g_file_make_directory_with_parents (GFile *file,
g_clear_error (&my_error); g_clear_error (&my_error);
g_file_make_directory (parent_file, cancellable, &my_error); g_file_make_directory (parent_file, cancellable, &my_error);
/* Another process may have created the directory in between the
* G_IO_ERROR_NOT_FOUND and now
*/
if (g_error_matches (my_error, G_IO_ERROR, G_IO_ERROR_EXISTS))
g_clear_error (&my_error);
g_object_unref (work_file); g_object_unref (work_file);
work_file = g_object_ref (parent_file); work_file = g_object_ref (parent_file);
@@ -3790,6 +3795,8 @@ g_file_make_directory_with_parents (GFile *file,
for (l = list; my_error == NULL && l; l = l->next) for (l = list; my_error == NULL && l; l = l->next)
{ {
g_file_make_directory ((GFile *) l->data, cancellable, &my_error); g_file_make_directory ((GFile *) l->data, cancellable, &my_error);
if (g_error_matches (my_error, G_IO_ERROR, G_IO_ERROR_EXISTS))
g_clear_error (&my_error);
} }
if (work_file) if (work_file)