From 5d38f3ebd40212ed212a509158c7a7697fddf4ba Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Thu, 18 Jan 2024 16:52:24 +0000 Subject: [PATCH] tests: Fix a double-unref in params tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This isn’t normally hit because it’s in a test which is disabled unless run with `-m thorough`. The `GParamSpec` is initially floating, but its floating ref is sunk by `g_object_interface_install_property()` (regardless of whether that call succeeds or aborts). The behaviour of `g_object_interface_install_property()` in this respect may have changed more recently than the test was written. Signed-off-by: Philip Withnall --- gobject/tests/param.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gobject/tests/param.c b/gobject/tests/param.c index 7696fc48f..76f1359e0 100644 --- a/gobject/tests/param.c +++ b/gobject/tests/param.c @@ -1157,7 +1157,6 @@ test_interface_default_init (TestInterfaceInterface *iface) g_object_interface_install_property (iface, pspec); g_test_assert_expected_messages (); - g_param_spec_unref (pspec); continue; }