luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-12 23:46:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

gsignal: Clarify signal detail format

Browse Source 
The format has never previously been specified. It can be anything, but
for sanity’s sake disallow empty strings.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: #358
This commit is contained in:
Philip Withnall 2019-11-12 20:59:40 +00:00
parent fb5cd1828f
commit 5e89ba5a74
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gobject/gsignal.c
View File

@ -98,6 +98,10 @@
* detail part of the signal specification upon connection) serves as a * detail part of the signal specification upon connection) serves as a
* wildcard and matches any detail argument passed in to emission. * wildcard and matches any detail argument passed in to emission.
* *
* While the @detail argument is typically used to pass an object property name
* (as with #GObject::notify), no specific format is mandated for the detail
* string, other than that it must be non-empty.
*
* ## Memory management of signal handlers # {#signal-memory-management} * ## Memory management of signal handlers # {#signal-memory-management}
* *
* If you are connecting handlers to signals and using a #GObject instance as * If you are connecting handlers to signals and using a #GObject instance as
@ -1158,6 +1162,9 @@ signal_parse_name (const gchar *name,
gchar buffer[32]; gchar buffer[32];
guint l = colon - name; guint l = colon - name;
if (colon[2] == '\0')
return 0;
if (l < 32) if (l < 32)
{ {
memcpy (buffer, name, l); memcpy (buffer, name, l);
@ -1175,7 +1182,7 @@ signal_parse_name (const gchar *name,
} }
if (signal_id && detail_p) if (signal_id && detail_p)
*detail_p = colon[2] ? (force_quark ? g_quark_from_string : g_quark_try_string) (colon + 2) : 0; *detail_p = (force_quark ? g_quark_from_string : g_quark_try_string) (colon + 2);
} }
else else
signal_id = 0; signal_id = 0;