luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-24 14:36:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

gmodule: change _g_module_close to only take a handle.

Browse Source 
Since is_unref |= 1, the second argument, gboolean is_unref, has had
no effect.
This commit is contained in:
Patrick Welche 2018-09-14 10:32:54 +01:00 committed by Philip Withnall
parent 407eae1969
commit 62f6c80e63
4 changed files with 10 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gmodule/gmodule-ar.c
View File

@ -141,20 +141,11 @@ _g_module_self (void)
}
static void
_g_module_close (gpointer handle,
gboolean is_unref)
{
/* are there any systems out there that have dlopen()/dlclose()
* without a reference count implementation?
*/
is_unref |= 1;
if (is_unref)
_g_module_close (gpointer handle)
{
if (dlclose (handle) != 0)
g_module_set_error (fetch_dlerror (TRUE));
}
}
static gpointer
_g_module_symbol (gpointer handle,

14
gmodule/gmodule-dl.c
View File

@ -131,21 +131,11 @@ _g_module_self (void)
}
static void
_g_module_close (gpointer handle,
gboolean is_unref)
_g_module_close (gpointer handle)
{
/* are there any systems out there that have dlopen()/dlclose()
* without a reference count implementation?
*
* See above for the Android special case
*/
#if defined(__BIONIC__)
is_unref = (handle != RTLD_DEFAULT);
#else
is_unref |= 1;
if (handle != RTLD_DEFAULT)
#endif
if (is_unref)
{
if (dlclose (handle) != 0)
g_module_set_error (fetch_dlerror (TRUE));

3
gmodule/gmodule-win32.c
View File

@ -113,8 +113,7 @@ _g_module_self (void)
}
static void
_g_module_close (gpointer handle,
gboolean is_unref)
_g_module_close (gpointer handle)
{
if (handle != null_module_handle)
if (!FreeLibrary (handle))

10
gmodule/gmodule.c
View File

@ -207,8 +207,7 @@ struct _GModule
static gpointer _g_module_open (const gchar *file_name,
gboolean bind_lazy,
gboolean bind_local);
static void _g_module_close (gpointer handle,
gboolean is_unref);
static void _g_module_close (gpointer handle);
static gpointer _g_module_self (void);
static gpointer _g_module_symbol (gpointer handle,
const gchar *symbol_name);
@ -297,8 +296,7 @@ _g_module_open (const gchar *file_name,
return NULL;
}
static void
_g_module_close (gpointer handle,
gboolean is_unref)
_g_module_close (gpointer handle)
{
}
static gpointer
@ -615,7 +613,7 @@ g_module_open (const gchar *file_name,
module = g_module_find_by_handle (handle);
if (module)
{
_g_module_close (module->handle, TRUE);
_g_module_close (module->handle);
module->ref_count++;
g_module_set_error (NULL);
@ -721,7 +719,7 @@ g_module_close (GModule *module)
}
module->next = NULL;
_g_module_close (module->handle, FALSE);
_g_module_close (module->handle);
g_free (module->file_name);
g_free (module);
}