luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-13 07:56:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Protect ourselves against properties with no default value

Browse Source 
If the GParamSpec does not have a default value, we should not try to
turn it into a string.
This commit is contained in:
Emmanuele Bassi 2023-03-20 18:49:40 +00:00 committed by Emmanuele Bassi
parent ffba6509da
commit 650090eefb
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdump.c
View File

@ -125,6 +125,9 @@ invoke_error_quark (GModule *self, const char *symbol, GError **error)
static char * static char *
value_to_string (const GValue *value) value_to_string (const GValue *value)
{ {
if (value == NULL)
return NULL;
if (G_VALUE_HOLDS_STRING (value)) if (G_VALUE_HOLDS_STRING (value))
{ {
const char *s = g_value_get_string (value); const char *s = g_value_get_string (value);
@ -186,7 +189,7 @@ dump_properties (GType type, GOutputStream *out)
const GValue *v = g_param_spec_get_default_value (prop); const GValue *v = g_param_spec_get_default_value (prop);
char *default_value = value_to_string (v); char *default_value = value_to_string (v);
if (default_value != NULL) if (v != NULL && default_value != NULL)
{ {
escaped_printf (out, " <property name=\"%s\" type=\"%s\" flags=\"%d\" default-value=\"%s\"/>\n", escaped_printf (out, " <property name=\"%s\" type=\"%s\" flags=\"%d\" default-value=\"%s\"/>\n",
prop->name, prop->name,