luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-11-03 17:48:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

gtype: make these cases fatal.

Browse Source 
Otherwise we crash with a null-ptr deref in g_object_newv and ever there we
should not return null, as we're saying that object creation will not return
null.
This commit is contained in:
Stefan Sauer
2012-06-12 20:22:39 +02:00
parent 0866e1ede9
commit 6c1276eb5f
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gobject/gtype.c
View File

@@ -1854,16 +1854,14 @@ g_type_create_instance (GType type)
node = lookup_type_node_I (type); node = lookup_type_node_I (type);
if (!node || !node->is_instantiatable) if (!node || !node->is_instantiatable)
{ {
g_warning ("cannot create new instance of invalid (non-instantiatable) type `%s'", g_error ("cannot create new instance of invalid (non-instantiatable) type `%s'",
type_descriptive_name_I (type)); type_descriptive_name_I (type));
return NULL;
} }
/* G_TYPE_IS_ABSTRACT() is an external call: _U */ /* G_TYPE_IS_ABSTRACT() is an external call: _U */
if (!node->mutatable_check_cache && G_TYPE_IS_ABSTRACT (type)) if (!node->mutatable_check_cache && G_TYPE_IS_ABSTRACT (type))
{ {
g_warning ("cannot create instance of abstract (non-instantiatable) type `%s'", g_error ("cannot create instance of abstract (non-instantiatable) type `%s'",
type_descriptive_name_I (type)); type_descriptive_name_I (type));
return NULL;
} }
class = g_type_class_ref (type); class = g_type_class_ref (type);