luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-04-01 21:33:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

gspawn: Don’t use g_close() in async-signal-safe context

Browse Source 
Use normal `close()` instead, which is guaranteed to be
async-signal-safe.

See `man 7 signal-safety`.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: #2140
This commit is contained in:
Philip Withnall 2020-06-22 13:09:56 +01:00
parent 0e05ef7750
commit 6f46294227
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
glib/gspawn.c
View File

@ -155,6 +155,7 @@ extern char **environ;
*/ */
static gint safe_close (gint fd);
static gint g_execute (const gchar *file, static gint g_execute (const gchar *file,
gchar **argv, gchar **argv,
@ -273,8 +274,7 @@ close_and_invalidate (gint *fd)
return; return;
else else
{ {
/* FIXME: g_close() is not async-signal-safe on failure. */ safe_close (*fd);
(void) g_close (*fd, NULL);
*fd = -1; *fd = -1;
} }
} }