luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-05 00:46:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

gbacktrace: Print out gdb exec errors correctly

Browse Source 
We want to see error messages related to starting and running
gdb (such as if it's not installed).

https://bugzilla.gnome.org/show_bug.cgi?id=711088
This commit is contained in:
Stef Walter 2013-10-29 18:03:29 +01:00
parent b1af471a3f
commit 6f7d8f6294
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
glib/gbacktrace.c
View File

@ -64,6 +64,8 @@
# define _WIN32_WINDOWS 0x0401 /* to get IsDebuggerPresent */ # define _WIN32_WINDOWS 0x0401 /* to get IsDebuggerPresent */
# include <windows.h> # include <windows.h>
# undef STRICT # undef STRICT
#else
# include <fcntl.h>
#endif #endif
#include "gbacktrace.h" #include "gbacktrace.h"
@ -298,12 +300,19 @@ stack_trace (char **args)
pid = fork (); pid = fork ();
if (pid == 0) if (pid == 0)
{ {
/* Save stderr for printing failure below */
int old_err = dup (2);
fcntl (old_err, F_SETFD, fcntl (old_err, F_GETFD) | FD_CLOEXEC);
close (0); dup (in_fd[0]); /* set the stdin to the in pipe */ close (0); dup (in_fd[0]); /* set the stdin to the in pipe */
close (1); dup (out_fd[1]); /* set the stdout to the out pipe */ close (1); dup (out_fd[1]); /* set the stdout to the out pipe */
close (2); dup (out_fd[1]); /* set the stderr to the out pipe */ close (2); dup (out_fd[1]); /* set the stderr to the out pipe */
execvp (args[0], args); /* exec gdb */ execvp (args[0], args); /* exec gdb */
perror ("exec failed");
/* Print failure to original stderr */
close (2); dup (old_err);
perror ("exec gdb failed");
_exit (0); _exit (0);
} }
else if (pid == (pid_t) -1) else if (pid == (pid_t) -1)