luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-26 12:12:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

gdbusobjectmanagerservice: fix leak in error path

Browse Source 
If the third g_return_val_if_fail() is hit, then we leak
orig_object_path. There is no reason we need to strdup it here.

Found by Coverity.
This commit is contained in:
Michael Catanzaro 2021-03-31 14:23:13 -05:00
parent 2b29495bcb
commit 719484a575
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gio/gdbusobjectmanagerserver.c
View File

@ -565,12 +565,12 @@ void
g_dbus_object_manager_server_export_uniquely (GDBusObjectManagerServer *manager, g_dbus_object_manager_server_export_uniquely (GDBusObjectManagerServer *manager,
GDBusObjectSkeleton *object) GDBusObjectSkeleton *object)
{ {
gchar *orig_object_path; const gchar *orig_object_path;
gchar *object_path; gchar *object_path;
guint count; guint count;
gboolean modified; gboolean modified;
orig_object_path = g_strdup (g_dbus_object_get_object_path (G_DBUS_OBJECT (object))); orig_object_path = g_dbus_object_get_object_path (G_DBUS_OBJECT (object));
g_return_if_fail (G_IS_DBUS_OBJECT_MANAGER_SERVER (manager)); g_return_if_fail (G_IS_DBUS_OBJECT_MANAGER_SERVER (manager));
g_return_if_fail (G_IS_DBUS_OBJECT (object)); g_return_if_fail (G_IS_DBUS_OBJECT (object));
@ -602,7 +602,6 @@ g_dbus_object_manager_server_export_uniquely (GDBusObjectManagerServer *manager,
g_dbus_object_skeleton_set_object_path (G_DBUS_OBJECT_SKELETON (object), object_path); g_dbus_object_skeleton_set_object_path (G_DBUS_OBJECT_SKELETON (object), object_path);
g_free (object_path); g_free (object_path);
g_free (orig_object_path);
} }