luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-03-01 13:42:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

g_file_make_directory_with_parents: refix error propagation

Browse Source 
The patch from b0bce4ad triggered segfaults - see:

 http://redmine.yorba.org/issues/5656

We were clearing the error before dereferencing it in the next
go-around of the while loop - this wasn't necessary.

https://bugzilla.gnome.org/show_bug.cgi?id=680823
This commit is contained in:
Owen W. Taylor 2012-08-14 11:00:14 -04:00 committed by Matthias Clasen
parent b60168a5f5
commit 732470a359
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gio/gfile.c
View File

@ -3395,10 +3395,7 @@ g_file_make_directory_with_parents (GFile *file,
work_file = g_object_ref (parent_file); work_file = g_object_ref (parent_file);
if (!result && my_error->code == G_IO_ERROR_NOT_FOUND) if (!result && my_error->code == G_IO_ERROR_NOT_FOUND)
{ list = g_list_prepend (list, parent_file); /* Transfer ownership of ref */
g_clear_error (&my_error);
list = g_list_prepend (list, parent_file); /* Transfer ownership of ref */
}
else else
g_object_unref (parent_file); g_object_unref (parent_file);
} }