luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-26 07:26:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

kqueue: Fix invalid emission of G_FILE_MONITOR_EVENT_MOVED event

Browse Source 
That event is deprecated, and the kqueue backend can’t provide enough
information to go alongside the event (i.e. the name of the new file).
Use G_FILE_MONITOR_EVENT_DELETED instead.

Quite disappointed in the kqueue documentation for this: I cannot find a
single piece of documentation or example about how NOTE_RENAME is
supposed to communicate the new name of the file.

If it turns out that this is possible, the code can be amended again in
future. At least now it doesn’t abort.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

https://bugzilla.gnome.org/show_bug.cgi?id=776147
This commit is contained in:
Philip Withnall 2017-11-10 15:10:26 +00:00
parent 7d3e6738c5
commit 76072a2dde
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gio/kqueue/kqueue-helper.c
View File

@ -97,8 +97,10 @@ convert_kqueue_events_to_gio (uint32_t flags, gboolean *done)
} }
if (flags & NOTE_RENAME) if (flags & NOTE_RENAME)
{ {
/* Since there’s apparently no way to get the new name of the file out of
* kqueue(), all we can do is say that this one has been deleted. */
*done = TRUE; *done = TRUE;
return G_FILE_MONITOR_EVENT_MOVED; return G_FILE_MONITOR_EVENT_DELETED;
} }
if (flags & NOTE_REVOKE) if (flags & NOTE_REVOKE)
{ {