From 769e3edbe0f658ecaf22d7352486aad176095328 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Thu, 2 May 2013 16:50:01 +0100 Subject: [PATCH] GSocks5Proxy: don't crash if parsing negotiation reply fails The GError should be initialized to NULL, otherwise we'll "pile up" errors, then try to free an uninitialized pointer. Signed-off-by: Simon McVittie Bug: https://bugzilla.gnome.org/show_bug.cgi?id=699493 --- gio/gsocks5proxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gio/gsocks5proxy.c b/gio/gsocks5proxy.c index 9d9055ffa..0d6269e3b 100644 --- a/gio/gsocks5proxy.c +++ b/gio/gsocks5proxy.c @@ -708,7 +708,7 @@ nego_reply_read_cb (GObject *source, if (data->offset == data->length) { - GError *error; + GError *error = NULL; gboolean must_auth = FALSE; gboolean has_auth = data->username || data->password;