luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-04-01 21:33:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

gdbusdaemon: Add an assertion to help static analysis of refcounts

Browse Source 
This should fix a scan-build warning about the final `name_unref()` here
being a use-after-free.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
This commit is contained in:
Philip Withnall 2022-05-10 16:17:38 +01:00
parent 86927c39e0
commit 7767978725
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gio/gdbusdaemon.c
View File

@ -874,7 +874,11 @@ client_free (Client *client)
name_ref (name); name_ref (name);
if (name->owner && name->owner->client == client) if (name->owner && name->owner->client == client)
{
/* Help static analysers with the refcount at this point. */
g_assert (name->refcount >= 2);
name_release_owner (name); name_release_owner (name);
}
name_unqueue_owner (name, client); name_unqueue_owner (name, client);