luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-11 15:06:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Bug 600550 - (...) doesn't treat arguments properly

Browse Source 
Add some additional checking to g_app_info_create_from_commandline to
make it handle strange inputs more elegantly.
This commit is contained in:
Christian Dywan 2009-11-19 09:58:43 -06:00 committed by Ryan Lortie
parent 3257e8ebe4
commit 77baa70eda
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gio/gdesktopappinfo.c
View File

@ -1607,6 +1607,8 @@ g_app_info_create_from_commandline (const char *commandline,
char *basename; char *basename;
GDesktopAppInfo *info; GDesktopAppInfo *info;
g_return_val_if_fail (commandline, NULL);
info = g_object_new (G_TYPE_DESKTOP_APP_INFO, NULL); info = g_object_new (G_TYPE_DESKTOP_APP_INFO, NULL);
info->filename = NULL; info->filename = NULL;
@ -1628,7 +1630,7 @@ g_app_info_create_from_commandline (const char *commandline,
{ {
/* FIXME: this should be more robust. Maybe g_shell_parse_argv and use argv[0] */ /* FIXME: this should be more robust. Maybe g_shell_parse_argv and use argv[0] */
split = g_strsplit (commandline, " ", 2); split = g_strsplit (commandline, " ", 2);
basename = g_path_get_basename (split[0]); basename = split[0] ? g_path_get_basename (split[0]) : NULL;
g_strfreev (split); g_strfreev (split);
info->name = basename; info->name = basename;
if (info->name == NULL) if (info->name == NULL)