luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-03-15 04:05:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'wip/pwithnall/2785-macos-fd-close-test-failure' into 'main'

Browse Source 
gstdio: Temporarily disable g_close() warning on macOS

See merge request GNOME/glib!2977
This commit is contained in:
Philip Withnall 2022-10-19 09:52:29 +00:00
commit 7cc95e0211
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
glib/gstdio.c
View File

@ -1802,7 +1802,13 @@ g_close (gint fd,
* not necessarily in the caller of g_close(), but somebody else * not necessarily in the caller of g_close(), but somebody else
* might have wrongly closed fd. In any case, there is a serious bug * might have wrongly closed fd. In any case, there is a serious bug
* somewhere. */ * somewhere. */
/* FIXME: This causes a number of unit test failures on macOS.
* Disabling the message for now until someone with access to a
* macOS machine can investigate.
* See https://gitlab.gnome.org/GNOME/glib/-/issues/2785 */
#ifndef HAVE_COCOA
g_critical ("g_close(fd:%d) failed with EBADF. The tracking of file descriptors got messed up", fd); g_critical ("g_close(fd:%d) failed with EBADF. The tracking of file descriptors got messed up", fd);
#endif
} }
else else
{ {