luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-06-06 21:00:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

GIO: avoid a crash in calling portals

Browse Source 
When the OpenUri portal call fails, we were possibly
freeing uninitialized memory. Avoid that by initializing
path to NULL here.

See https://github.com/flatpak/xdg-desktop-portal/issues/173
This commit is contained in:
Matthias Clasen 2018-03-25 00:10:21 -04:00
parent 891026d9fc
commit 7e4a0d8479
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gio/gopenuriportal.c
View File

@ -203,7 +203,7 @@ open_call_done (GObject *source,
GError *error = NULL; GError *error = NULL;
gboolean open_file; gboolean open_file;
gboolean res; gboolean res;
char *path; char *path = NULL;
const char *handle; const char *handle;
guint signal_id; guint signal_id;
@ -224,7 +224,7 @@ open_call_done (GObject *source,
} }
handle = (const char *)g_object_get_data (G_OBJECT (task), "handle"); handle = (const char *)g_object_get_data (G_OBJECT (task), "handle");
if (strcmp (handle, path) != 0) if (g_strcmp0 (handle, path) != 0)
{ {
signal_id = GPOINTER_TO_UINT (g_object_get_data (G_OBJECT (task), "signal-id")); signal_id = GPOINTER_TO_UINT (g_object_get_data (G_OBJECT (task), "signal-id"));
g_dbus_connection_signal_unsubscribe (connection, signal_id); g_dbus_connection_signal_unsubscribe (connection, signal_id);