luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-12 23:46:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Support whitespace stripping for JSON resources

Browse Source 
Similarly to how glib-compile-resources can call xmllint to eliminate
whitespace in XML files to reduce their size inside a GResource, we can
use json-glib-format to achieve the same result.

The mechanism for using json-glib-format is the same, with a separate
environment variable if we want to direct glib-compile-resources to a
version of json-glib-format that is not the one in the PATH.

https://bugzilla.gnome.org/show_bug.cgi?id=794284
This commit is contained in:
Emmanuele Bassi 2018-03-13 11:49:59 +00:00
parent c672fcc0a8
commit 7fd17c4337
2 changed files with 59 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/reference/gio/glib-compile-resources.xml
View File

@ -216,6 +216,16 @@ environment variable is not set, gdk-pixbuf-pixdata is searched in the
</para></listitem> </para></listitem>
</varlistentry> </varlistentry>
<varlistentry>
<term><envar>JSON_GLIB_FORMAT</envar></term>
<listitem><para>
The full path to the json-glib-format executable. This is used to preprocess
resources with the <literal>json-stripblanks</literal> preprocessing option.
If this environment variable is not set, json-glib-format is searched in the
<envar>PATH</envar>.
</para></listitem>
</varlistentry>
</variablelist> </variablelist>
</refsect1> </refsect1>
</refentry> </refentry>

49
gio/glib-compile-resources.c
View File

@ -76,6 +76,7 @@ typedef struct
static gchar **sourcedirs = NULL; static gchar **sourcedirs = NULL;
static gchar *xmllint = NULL; static gchar *xmllint = NULL;
static gchar *jsonformat = NULL;
static gchar *gdk_pixbuf_pixdata = NULL; static gchar *gdk_pixbuf_pixdata = NULL;
static void static void
@ -274,6 +275,7 @@ end_element (GMarkupParseContext *context,
gchar **options; gchar **options;
guint i; guint i;
gboolean xml_stripblanks = FALSE; gboolean xml_stripblanks = FALSE;
gboolean json_stripblanks = FALSE;
gboolean to_pixdata = FALSE; gboolean to_pixdata = FALSE;
options = g_strsplit (state->preproc_options, ",", -1); options = g_strsplit (state->preproc_options, ",", -1);
@ -284,6 +286,8 @@ end_element (GMarkupParseContext *context,
xml_stripblanks = TRUE; xml_stripblanks = TRUE;
else if (!strcmp (options[i], "to-pixdata")) else if (!strcmp (options[i], "to-pixdata"))
to_pixdata = TRUE; to_pixdata = TRUE;
else if (!strcmp (options[i], "json-stripblanks"))
json_stripblanks = TRUE;
else else
{ {
g_set_error (error, G_MARKUP_ERROR, G_MARKUP_ERROR_INVALID_CONTENT, g_set_error (error, G_MARKUP_ERROR, G_MARKUP_ERROR_INVALID_CONTENT,
@ -332,6 +336,44 @@ end_element (GMarkupParseContext *context,
real_file = g_strdup (tmp_file); real_file = g_strdup (tmp_file);
} }
if (json_stripblanks && jsonformat != NULL)
{
int fd;
GSubprocess *proc;
tmp_file = g_strdup ("resource-XXXXXXXX");
if ((fd = g_mkstemp (tmp_file)) == -1)
{
int errsv = errno;
g_set_error (error, G_IO_ERROR, g_io_error_from_errno (errsv),
_("Failed to create temp file: %s"),
g_strerror (errsv));
g_free (tmp_file);
tmp_file = NULL;
goto cleanup;
}
close (fd);
proc = g_subprocess_new (G_SUBPROCESS_FLAGS_STDOUT_SILENCE, error,
jsonformat, "--output", tmp_file, real_file, NULL);
g_free (real_file);
real_file = NULL;
if (!proc)
goto cleanup;
if (!g_subprocess_wait_check (proc, NULL, error))
{
g_object_unref (proc);
goto cleanup;
}
g_object_unref (proc);
real_file = g_strdup (tmp_file);
}
if (to_pixdata) if (to_pixdata)
{ {
int fd; int fd;
@ -736,6 +778,12 @@ main (int argc, char **argv)
if (xmllint == NULL) if (xmllint == NULL)
g_printerr ("XMLLINT not set and xmllint not found in path; skipping xml preprocessing.\n"); g_printerr ("XMLLINT not set and xmllint not found in path; skipping xml preprocessing.\n");
jsonformat = g_strdup (g_getenv ("JSON_GLIB_FORMAT"));
if (jsonformat == NULL)
jsonformat = g_find_program_in_path ("json-glib-format");
if (jsonformat == NULL)
g_printerr ("JSON_GLIB_FORMAT not set and json-glib-format not found in path; skipping json pre-processing.\n");
gdk_pixbuf_pixdata = g_strdup (g_getenv ("GDK_PIXBUF_PIXDATA")); gdk_pixbuf_pixdata = g_strdup (g_getenv ("GDK_PIXBUF_PIXDATA"));
if (gdk_pixbuf_pixdata == NULL) if (gdk_pixbuf_pixdata == NULL)
gdk_pixbuf_pixdata = g_find_program_in_path ("gdk-pixbuf-pixdata"); gdk_pixbuf_pixdata = g_find_program_in_path ("gdk-pixbuf-pixdata");
@ -1096,6 +1144,7 @@ main (int argc, char **argv)
g_free (target); g_free (target);
g_hash_table_destroy (table); g_hash_table_destroy (table);
g_free (xmllint); g_free (xmllint);
g_free (jsonformat);
g_free (c_name); g_free (c_name);
g_hash_table_unref (files); g_hash_table_unref (files);