luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-11 11:56:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

grefcount: Optimise g_atomic_ref_count_inc

Browse Source 
Currently, `g_atomic_ref_count_inc ()` does three operations.
We try to get this down to one operation.

Fixed by replacing `g_atomic_int_inc ()` with `g_atomic_int_add ()`
which increments by 1 and returns old value

Note: changes current behaviour, checks are now done after increment.

Closes: #1583
This commit is contained in:
Nishal Kulkarni 2021-05-10 15:45:00 +05:30
parent 2cb303b7aa
commit 827b4ec855
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
glib/grefcount.c
View File

@ -235,16 +235,14 @@ void
void
(g_atomic_ref_count_inc) (gatomicrefcount *arc)
{
gint old_value;
g_return_if_fail (arc != NULL);
g_return_if_fail (g_atomic_int_get (arc) > 0);
old_value = g_atomic_int_add (arc, 1);
g_return_if_fail (old_value > 0);
if (g_atomic_int_get (arc) == G_MAXINT)
{
g_critical ("Reference count has reached saturation");
return;
}
g_atomic_int_inc (arc);
if (old_value == G_MAXINT)
g_critical ("Reference count has reached saturation");
}
/**