luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-10-31 08:22:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

gio: Add a query_exists vfunc to GFile

Browse Source 
g_file_query_exists looks like a simpler and faster api than
g_file_query_info. This vfunc lets us actually make it faster,
and avoid allocations in this frequently used code path.
This commit is contained in:
Matthias Clasen
2024-09-12 10:26:05 -04:00
committed by Philip Withnall
parent 6d408ea76e
commit 85ce99f4ad
2 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gio/gfile.c
View File

@@ -1192,8 +1192,11 @@ g_file_enumerate_children_finish (GFile *file,
* @cancellable: (nullable): optional #GCancellable object, * @cancellable: (nullable): optional #GCancellable object,
* %NULL to ignore * %NULL to ignore
* *
* Utility function to check if a particular file exists. This is * Utility function to check if a particular file exists.
* implemented using g_file_query_info() and as such does blocking I/O. *
* The fallback implementation of this API is using [method@Gio.File.query_info]
* and therefore may do blocking I/O. To asynchronously query the existence
* of a file, use [method@Gio.File.query_info_async].
* *
* Note that in many cases it is [racy to first check for file existence](https://en.wikipedia.org/wiki/Time_of_check_to_time_of_use) * Note that in many cases it is [racy to first check for file existence](https://en.wikipedia.org/wiki/Time_of_check_to_time_of_use)
* and then execute something based on the outcome of that, because the * and then execute something based on the outcome of that, because the
@@ -1222,10 +1225,16 @@ gboolean
g_file_query_exists (GFile *file, g_file_query_exists (GFile *file,
GCancellable *cancellable) GCancellable *cancellable)
{ {
GFileIface *iface;
GFileInfo *info; GFileInfo *info;
g_return_val_if_fail (G_IS_FILE (file), FALSE); g_return_val_if_fail (G_IS_FILE (file), FALSE);
iface = G_FILE_GET_IFACE (file);
if (iface->query_exists)
return iface->query_exists (file, cancellable);
info = g_file_query_info (file, G_FILE_ATTRIBUTE_STANDARD_TYPE, info = g_file_query_info (file, G_FILE_ATTRIBUTE_STANDARD_TYPE,
G_FILE_QUERY_INFO_NONE, cancellable, NULL); G_FILE_QUERY_INFO_NONE, cancellable, NULL);
if (info != NULL) if (info != NULL)

4
gio/gfile.h
View File

@@ -148,6 +148,7 @@ typedef struct _GFileIface GFileIface;
* @measure_disk_usage: Recursively measures the disk usage of @file. Since 2.38 * @measure_disk_usage: Recursively measures the disk usage of @file. Since 2.38
* @measure_disk_usage_async: Asynchronously recursively measures the disk usage of @file. Since 2.38 * @measure_disk_usage_async: Asynchronously recursively measures the disk usage of @file. Since 2.38
* @measure_disk_usage_finish: Finishes an asynchronous recursive measurement of the disk usage of @file. Since 2.38 * @measure_disk_usage_finish: Finishes an asynchronous recursive measurement of the disk usage of @file. Since 2.38
* @query_exists: Queries whether a file exists. Since 2.84
* *
* An interface for writing VFS file handles. * An interface for writing VFS file handles.
**/ **/
@@ -598,6 +599,9 @@ struct _GFileIface
guint64 *num_dirs, guint64 *num_dirs,
guint64 *num_files, guint64 *num_files,
GError **error); GError **error);
gboolean (* query_exists) (GFile *file,
GCancellable *cancellable);
}; };
GIO_AVAILABLE_IN_ALL GIO_AVAILABLE_IN_ALL