luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-24 03:02:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add more tests for GHmac

Browse Source 
This will test a few problems that we hit recently:

g_hmac_copy() is broken, https://bugzilla.redhat.com/show_bug.cgi?id=1786538

Crash in g_hmac_update() in FIPS mode, https://bugzilla.redhat.com/show_bug.cgi?id=1971533

Crash when passing -1 length to g_hmac_update() (discovered in #1971533)
This commit is contained in:
Michael Catanzaro 2021-07-01 15:51:26 -05:00
parent 3befcf1eb3
commit 87280b2390
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
glib/tests/hmac.c
View File

@ -493,6 +493,27 @@ test_hmac_for_bytes (void)
g_bytes_unref (data); g_bytes_unref (data);
} }
static void
test_ghmac_gnutls_regressions (void)
{
GHmac *hmac;
GHmac *copy;
hmac = g_hmac_new (G_CHECKSUM_SHA256, (const guchar *)"abc123", sizeof ("abc123"));
g_assert_nonnull (hmac);
/* Ensure g_hmac_update() does not crash when called with -1. */
g_hmac_update (hmac, (const guchar *)"You win again, gravity!", -1);
/* Ensure g_hmac_copy() does not crash. */
copy = g_hmac_copy (hmac);
g_assert_nonnull (hmac);
g_hmac_unref (hmac);
g_assert_cmpstr (g_hmac_get_string (copy), ==, "795ba6900bcb22e8ce65c2ec02db4e85697da921deb960ee3143bf88a4a60f83");
g_hmac_unref (copy);
}
int int
main (int argc, main (int argc,
char **argv) char **argv)
@ -545,6 +566,7 @@ main (int argc,
g_test_add_func ("/hmac/for-data", test_hmac_for_data); g_test_add_func ("/hmac/for-data", test_hmac_for_data);
g_test_add_func ("/hmac/for-string", test_hmac_for_string); g_test_add_func ("/hmac/for-string", test_hmac_for_string);
g_test_add_func ("/hmac/for-bytes", test_hmac_for_bytes); g_test_add_func ("/hmac/for-bytes", test_hmac_for_bytes);
g_test_add_func ("/hmac/ghmac-gnutls-regressions", test_ghmac_gnutls_regressions);
return g_test_run (); return g_test_run ();
} }