luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-03-03 14:42:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

gsocket: test if family is <= 0, not < 0

Browse Source 
If all members of GSocketFamily are supported on the platform, then
all of its values will be positive, and so the enum might become
unsigned, in which case testing for "family < 0" might cause warnings.
But we want to return an error if family == 0 (aka
G_SOCKET_FAMILY_INVALID) anyway, so just tweak the test accordingly.

https://bugzilla.gnome.org/show_bug.cgi?id=674592
This commit is contained in:
Dan Winship 2012-04-25 10:44:55 -04:00
parent 56bcba11dd
commit 87cc77a198
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gio/gsocket.c
View File

@ -500,7 +500,7 @@ g_socket_create_socket (GSocketFamily family,
g_assert_not_reached (); g_assert_not_reached ();
} }
if (family < 0) if (family <= 0)
{ {
g_set_error (error, G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT, g_set_error (error, G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT,
_("Unable to create socket: %s"), _("Unknown family was specified")); _("Unable to create socket: %s"), _("Unknown family was specified"));