luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-03-28 02:20:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

dataset: Document some logic

Browse Source 
Add comments to clarify how the 'old' array is allocated and used.
This commit is contained in:
Peter Bloomfield 2022-06-27 17:53:25 -04:00
parent 8bd63258a5
commit 8a43ae71c8
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
glib/gdataset.c
View File

@ -504,6 +504,11 @@ g_data_remove_internal (GData **datalist,
GDataElt *old, *data, *data_end; GDataElt *old, *data, *data_end;
gsize found_keys; gsize found_keys;
/* Allocate an array of GDataElt to hold copies of the elements
* that are removed from the datalist. Allow enough space for all
* the keys; if a key is not found, the corresponding element of
* old is not populated, so we initialize them all to NULL to
* detect that case. */
old = g_newa0 (GDataElt, n_keys); old = g_newa0 (GDataElt, n_keys);
data = d->data; data = d->data;
@ -558,6 +563,9 @@ g_data_remove_internal (GData **datalist,
for (gsize i = 0; i < n_keys; i++) for (gsize i = 0; i < n_keys; i++)
{ {
/* If keys[i] was not found, then old[i].destroy is NULL.
* Call old[i].destroy() only if keys[i] was found, and
* is associated with a destroy notifier: */
if (old[i].destroy) if (old[i].destroy)
old[i].destroy (old[i].data); old[i].destroy (old[i].data);
} }