luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-10-05 13:19:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Reduce false positives in static analysis

Browse Source 
Tools like clang fail to recognize that stanzas like
g_return_if_fail (GTK_IS_FOO (w)) guarantee w != NULL. By minimally
rewriting the type-checking macros, we can avoid these false positives.
This commit is contained in:
Matthias Clasen
2009-09-18 19:16:11 -04:00
parent 53fc10d269
commit 8b3853b8a1
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gobject/gtype.h
View File

@@ -1475,7 +1475,9 @@ G_GNUC_INTERNAL void g_signal_init (void); /* sync with gsignal.c *
#ifdef __GNUC__ #ifdef __GNUC__
# define _G_TYPE_CIT(ip, gt) (G_GNUC_EXTENSION ({ \ # define _G_TYPE_CIT(ip, gt) (G_GNUC_EXTENSION ({ \
GTypeInstance *__inst = (GTypeInstance*) ip; GType __t = gt; gboolean __r; \ GTypeInstance *__inst = (GTypeInstance*) ip; GType __t = gt; gboolean __r; \
if (__inst && __inst->g_class && __inst->g_class->g_type == __t) \ if (!__inst) \
__r = FALSE; \
else if (__inst->g_class && __inst->g_class->g_type == __t) \
__r = TRUE; \ __r = TRUE; \
else \ else \
__r = g_type_check_instance_is_a (__inst, __t); \ __r = g_type_check_instance_is_a (__inst, __t); \
@@ -1483,7 +1485,9 @@ G_GNUC_INTERNAL void g_signal_init (void); /* sync with gsignal.c *
})) }))
# define _G_TYPE_CCT(cp, gt) (G_GNUC_EXTENSION ({ \ # define _G_TYPE_CCT(cp, gt) (G_GNUC_EXTENSION ({ \
GTypeClass *__class = (GTypeClass*) cp; GType __t = gt; gboolean __r; \ GTypeClass *__class = (GTypeClass*) cp; GType __t = gt; gboolean __r; \
if (__class && __class->g_type == __t) \ if (!__class) \
__r = FALSE; \
else if (__class->g_type == __t) \
__r = TRUE; \ __r = TRUE; \
else \ else \
__r = g_type_check_class_is_a (__class, __t); \ __r = g_type_check_class_is_a (__class, __t); \
@@ -1491,7 +1495,9 @@ G_GNUC_INTERNAL void g_signal_init (void); /* sync with gsignal.c *
})) }))
# define _G_TYPE_CVH(vl, gt) (G_GNUC_EXTENSION ({ \ # define _G_TYPE_CVH(vl, gt) (G_GNUC_EXTENSION ({ \
GValue *__val = (GValue*) vl; GType __t = gt; gboolean __r; \ GValue *__val = (GValue*) vl; GType __t = gt; gboolean __r; \
if (__val && __val->g_type == __t) \ if (!__val) \
__r = FALSE; \
if (__val->g_type == __t) \
__r = TRUE; \ __r = TRUE; \
else \ else \
__r = g_type_check_value_holds (__val, __t); \ __r = g_type_check_value_holds (__val, __t); \