luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-11-12 13:52:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

GMainContext: unref pending sources on destroy

Browse Source 
It is possible (but unlikely) that there will be a non-empty list of
pending dispatches when we remove the last ref from a GMainContext.
Make sure we drop the refs on the sources appropriately.

Add a (now-working) testcase that demonstrates how to trigger the issue.

https://bugzilla.gnome.org/show_bug.cgi?id=139699
This commit is contained in:
Ryan Lortie
2013-10-25 01:47:37 -04:00
committed by Matthias Clasen
parent 2a3ee7ceaf
commit 8f6be404cb
2 changed files with 47 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
glib/gmain.c
View File

@@ -507,6 +507,7 @@ g_main_context_unref (GMainContext *context)
GSource *source;
GList *sl_iter;
GSourceList *list;
gint i;
g_return_if_fail (context != NULL);
g_return_if_fail (g_atomic_int_get (&context->ref_count) > 0);
@@ -518,6 +519,10 @@ g_main_context_unref (GMainContext *context)
main_context_list = g_slist_remove (main_context_list, context);
G_UNLOCK (main_context_list);
/* Free pending dispatches */
for (i = 0; i < context->pending_dispatches->len; i++)
g_source_unref_internal (context->pending_dispatches->pdata[i], context, FALSE);
/* g_source_iter_next() assumes the context is locked. */
LOCK_CONTEXT (context);
g_source_iter_init (&iter, context, TRUE);