luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-08-19 23:28:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't leak an error

Browse Source 
The previous commit introduced a possible memory leak in cases
where we get a G_IO_ERROR_CLOSED error. Make sure to always
free an error, if we got one.

https://bugzilla.gnome.org/show_bug.cgi?id=753278
This commit is contained in:
Matthias Clasen
2015-08-05 17:18:48 -04:00
parent b3fcb1442e
commit 905e916573
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gio/gdbusobjectmanagerserver.c
View File

@@ -929,9 +929,10 @@ g_dbus_object_manager_server_emit_interfaces_added (GDBusObjectManagerServer *ma
object_path, object_path,
&array_builder), &array_builder),
&error); &error);
if (error && !g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CLOSED)) if (error)
{ {
g_warning ("Couldn't emit InterfacesAdded signal: %s", error->message); if (!g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CLOSED))
g_warning ("Couldn't emit InterfacesAdded signal: %s", error->message);
g_error_free (error); g_error_free (error);
} }
out: out:
@@ -966,9 +967,10 @@ g_dbus_object_manager_server_emit_interfaces_removed (GDBusObjectManagerServer *
object_path, object_path,
&array_builder), &array_builder),
&error); &error);
if (error && !g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CLOSED)) if (error)
{ {
g_warning ("Couldn't emit InterfacesRemoved signal: %s", error->message); if (!g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CLOSED))
g_warning ("Couldn't emit InterfacesRemoved signal: %s", error->message);
g_error_free (error); g_error_free (error);
} }
out: out: