luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-05-04 21:16:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

gtask: Document signal handler reference counting

Browse Source 
Explain why the signal handler holds a reference to the GTask, even
though that causes a reference loop at first glance.

https://bugzilla.gnome.org/show_bug.cgi?id=736806
This commit is contained in:
Philip Withnall 2014-09-17 17:20:46 +01:00
parent c6838ffaa1
commit 925913d8dd
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gio/gtask.c
View File

@ -1274,6 +1274,14 @@ g_task_start_task_thread (GTask *task,
return; return;
} }
/* This introduces a reference count loop between the GTask and
* GCancellable, but is necessary to avoid a race on finalising the GTask
* between task_thread_cancelled() (in one thread) and
* g_task_thread_complete() (in another).
*
* Accordingly, the signal handler *must* be removed once the task has
* completed.
*/
g_signal_connect_data (task->cancellable, "cancelled", g_signal_connect_data (task->cancellable, "cancelled",
G_CALLBACK (task_thread_cancelled), G_CALLBACK (task_thread_cancelled),
g_object_ref (task), g_object_ref (task),