luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-08-19 15:18:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

gfile: Add support for x-gvfs-trash mount option

Browse Source 
Currently, the trash functionality is disabled for system internal mounts.
That might be a problem in some cases. The `x-gvfs-notrash` mount option
allows disabling the trash functionality for certain mounts. Let's add
support for the `x-gvfs-trash` mount option to allow the opposite.

See: https://issues.redhat.com/browse/RHEL-46828
This commit is contained in:
Ondrej Holy
2024-07-12 11:14:10 +02:00
committed by Michael Catanzaro
parent 9cd71b6e56
commit 93c46e9c1c
2 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gio/gfile.c
View File

@@ -4165,10 +4165,13 @@ g_file_delete_finish (GFile *file,
* *
* Sends @file to the "Trashcan", if possible. This is similar to * Sends @file to the "Trashcan", if possible. This is similar to
* deleting it, but the user can recover it before emptying the trashcan. * deleting it, but the user can recover it before emptying the trashcan.
* Not all file systems support trashing, so this call can return the * Trashing is disabled for system mounts by default (see
* g_unix_mount_is_system_internal()), so this call can return the
* %G_IO_ERROR_NOT_SUPPORTED error. Since GLib 2.66, the `x-gvfs-notrash` unix * %G_IO_ERROR_NOT_SUPPORTED error. Since GLib 2.66, the `x-gvfs-notrash` unix
* mount option can be used to disable g_file_trash() support for certain * mount option can be used to disable g_file_trash() support for particular
* mounts, the %G_IO_ERROR_NOT_SUPPORTED error will be returned in that case. * mounts, the %G_IO_ERROR_NOT_SUPPORTED error will be returned in that case.
* Since 2.82, the `x-gvfs-trash` unix mount option can be used to enable
* g_file_trash() support for particular system mounts.
* *
* If @cancellable is not %NULL, then the operation can be cancelled by * If @cancellable is not %NULL, then the operation can be cancelled by
* triggering the cancellable object from another thread. If the operation * triggering the cancellable object from another thread. If the operation

24
gio/glocalfile.c
View File

@@ -1863,10 +1863,6 @@ ignore_trash_mount (GUnixMountEntry *mount)
{ {
GUnixMountPoint *mount_point = NULL; GUnixMountPoint *mount_point = NULL;
const gchar *mount_options; const gchar *mount_options;
gboolean retval = TRUE;
if (g_unix_mount_is_system_internal (mount))
return TRUE;
mount_options = g_unix_mount_get_options (mount); mount_options = g_unix_mount_get_options (mount);
if (mount_options == NULL) if (mount_options == NULL)
@@ -1875,15 +1871,23 @@ ignore_trash_mount (GUnixMountEntry *mount)
NULL); NULL);
if (mount_point != NULL) if (mount_point != NULL)
mount_options = g_unix_mount_point_get_options (mount_point); mount_options = g_unix_mount_point_get_options (mount_point);
}
if (mount_options == NULL ||
strstr (mount_options, "x-gvfs-notrash") == NULL)
retval = FALSE;
g_clear_pointer (&mount_point, g_unix_mount_point_free); g_clear_pointer (&mount_point, g_unix_mount_point_free);
}
return retval; if (mount_options != NULL)
{
if (strstr (mount_options, "x-gvfs-trash") != NULL)
return FALSE;
if (strstr (mount_options, "x-gvfs-notrash") != NULL)
return TRUE;
}
if (g_unix_mount_is_system_internal (mount))
return TRUE;
return FALSE;
} }
static gboolean static gboolean