luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-08-20 15:48:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

docs: better documentation for g_file_info_copy_into()

Browse Source 
The documentation of g_file_info_copy_into() was misleading. The
attributes are not just copied, @dest_info is also cleared at the
beginning. So any previously set attributes in @dest_info are lost.

There was a bug in gedit about this function, where some metadata were
not saved. So it might make sense to change the implementation to not
clear @dest_info, and copy one by one the attributes from @src_info to
@dest_info.

https://bugzilla.gnome.org/show_bug.cgi?id=747927
This commit is contained in:
Sébastien Wilmet
2015-04-15 14:28:05 +02:00
parent f14052461b
commit 95dd373024
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gio/gfileinfo.c
View File

@@ -365,8 +365,8 @@ g_file_info_new (void)
* @src_info: source to copy attributes from. * @src_info: source to copy attributes from.
* @dest_info: destination to copy attributes to. * @dest_info: destination to copy attributes to.
* *
* Copies all of the [GFileAttribute][gio-GFileAttribute] * First clears all of the [GFileAttribute][gio-GFileAttribute] of @dest_info,
* from @src_info to @dest_info. * and then copies all of the file attributes from @src_info to @dest_info.
**/ **/
void void
g_file_info_copy_into (GFileInfo *src_info, g_file_info_copy_into (GFileInfo *src_info,