luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-08-10 03:04:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

gio: Fix C99 style variable declarations (bug #633075)

Browse Source 
-gdbusmessage.c and gregistrysettingsbackend.c is updated to fix C99-style declarations
-also fixed typo for displaying registry entry in gregistrysettingsbackend.c (\% -> \\%)
This commit is contained in:
Chun-wei Fan
2010-11-09 20:36:53 +08:00
parent 029f3070e7
commit 9f02ee790b
2 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gio/gdbusmessage.c
View File

@@ -1186,7 +1186,10 @@ parse_value_from_blob (GMemoryInputStream *mis,
v = g_data_input_stream_read_uint64 (dis, NULL, &local_error); v = g_data_input_stream_read_uint64 (dis, NULL, &local_error);
if (local_error != NULL) if (local_error != NULL)
goto fail; goto fail;
G_STATIC_ASSERT (sizeof (gdouble) == sizeof (guint64)); if (1)
{
G_STATIC_ASSERT (sizeof (gdouble) == sizeof (guint64));
}
encoded = (gdouble *) &v; encoded = (gdouble *) &v;
ret = g_variant_new_double (*encoded); ret = g_variant_new_double (*encoded);
} }

21
gio/gregistrysettingsbackend.c
View File

@@ -569,6 +569,7 @@ registry_cache_get_node_for_key_recursive (GNode *node,
RegistryCacheItem *item; RegistryCacheItem *item;
gchar *component = key_name, gchar *component = key_name,
*c = strchr (component, '/'); *c = strchr (component, '/');
GNode *child;
if (c != NULL) if (c != NULL)
*c = 0; *c = 0;
@@ -581,7 +582,7 @@ registry_cache_get_node_for_key_recursive (GNode *node,
if (item->subscription_count > 0) if (item->subscription_count > 0)
n_parent_watches ++; n_parent_watches ++;
GNode *child = registry_cache_find_immediate_child (node, component); child = registry_cache_find_immediate_child (node, component);
if (child == NULL && create_if_not_found) if (child == NULL && create_if_not_found)
{ {
item = g_slice_new (RegistryCacheItem); item = g_slice_new (RegistryCacheItem);
@@ -904,6 +905,8 @@ g_registry_backend_write_one (const char *key_name,
GNode *node; GNode *node;
gboolean changed; gboolean changed;
const gchar *type_string = g_variant_get_type_string (variant);
action = user_data; action = user_data;
self = G_REGISTRY_BACKEND (action->self); self = G_REGISTRY_BACKEND (action->self);
hroot = action->hroot; hroot = action->hroot;
@@ -911,7 +914,6 @@ g_registry_backend_write_one (const char *key_name,
value.type = REG_NONE; value.type = REG_NONE;
value.ptr = NULL; value.ptr = NULL;
const gchar *type_string = g_variant_get_type_string (variant);
switch (type_string[0]) switch (type_string[0])
{ {
case 'b': case 'y': case 'n': case 'q': case 'i': case 'u': case 'b': case 'y': case 'n': case 'q': case 'i': case 'u':
@@ -984,7 +986,7 @@ g_registry_backend_write_one (const char *key_name,
result = RegSetValueExA (hpath, value_name, 0, value.type, value_data, value_data_size); result = RegSetValueExA (hpath, value_name, 0, value.type, value_data, value_data_size);
if (result != ERROR_SUCCESS) if (result != ERROR_SUCCESS)
g_message_win32_error (result, "gregistrybackend: setting value %s\%s\\%s failed.\n", g_message_win32_error (result, "gregistrybackend: setting value %s\\%s\\%s failed.\n",
self->base_path, path_name, value_name); self->base_path, path_name, value_name);
/* If the write fails then it will seem like the value has changed until the /* If the write fails then it will seem like the value has changed until the
@@ -1011,6 +1013,7 @@ g_registry_backend_write (GSettingsBackend *backend,
GRegistryBackend *self = G_REGISTRY_BACKEND (backend); GRegistryBackend *self = G_REGISTRY_BACKEND (backend);
LONG result; LONG result;
HKEY hroot; HKEY hroot;
RegistryWrite action;
result = RegCreateKeyExA (HKEY_CURRENT_USER, self->base_path, 0, NULL, 0, result = RegCreateKeyExA (HKEY_CURRENT_USER, self->base_path, 0, NULL, 0,
KEY_WRITE, NULL, &hroot, NULL); KEY_WRITE, NULL, &hroot, NULL);
@@ -1019,7 +1022,8 @@ g_registry_backend_write (GSettingsBackend *backend,
return FALSE; return FALSE;
} }
RegistryWrite action = { self, hroot }; action.self = self;
action.hroot = hroot;
g_registry_backend_write_one (key_name, value, &action); g_registry_backend_write_one (key_name, value, &action);
g_settings_backend_changed (backend, key_name, origin_tag); g_settings_backend_changed (backend, key_name, origin_tag);
@@ -1036,6 +1040,7 @@ g_registry_backend_write_tree (GSettingsBackend *backend,
GRegistryBackend *self = G_REGISTRY_BACKEND (backend); GRegistryBackend *self = G_REGISTRY_BACKEND (backend);
LONG result; LONG result;
HKEY hroot; HKEY hroot;
RegistryWrite action;
result = RegCreateKeyExA (HKEY_CURRENT_USER, self->base_path, 0, NULL, 0, result = RegCreateKeyExA (HKEY_CURRENT_USER, self->base_path, 0, NULL, 0,
KEY_WRITE, NULL, &hroot, NULL); KEY_WRITE, NULL, &hroot, NULL);
@@ -1044,7 +1049,8 @@ g_registry_backend_write_tree (GSettingsBackend *backend,
return FALSE; return FALSE;
} }
RegistryWrite action = { self, hroot }; action.self = self;
action.hroot = hroot;
g_tree_foreach (values, (GTraverseFunc)g_registry_backend_write_one, g_tree_foreach (values, (GTraverseFunc)g_registry_backend_write_one,
&action); &action);
@@ -1144,11 +1150,11 @@ registry_cache_destroy_tree (GNode *node,
if (item->subscription_count > 0) if (item->subscription_count > 0)
{ {
gint i;
/* There must be some watches active if this node is a watch point */ /* There must be some watches active if this node is a watch point */
g_warn_if_fail (self->cache_nodes->len > 1); g_warn_if_fail (self->cache_nodes->len > 1);
/* This is a watch point that has been deleted. Let's free the watch! */ /* This is a watch point that has been deleted. Let's free the watch! */
gint i;
for (i=1; i<self->cache_nodes->len; i++) for (i=1; i<self->cache_nodes->len; i++)
if (g_ptr_array_index (self->cache_nodes, i) == node) if (g_ptr_array_index (self->cache_nodes, i) == node)
break; break;
@@ -1953,9 +1959,10 @@ g_registry_backend_class_init (GRegistryBackendClass *class)
static void static void
g_registry_backend_init (GRegistryBackend *self) g_registry_backend_init (GRegistryBackend *self)
{ {
RegistryCacheItem *item;
self->base_path = g_strdup_printf ("Software\\GSettings"); self->base_path = g_strdup_printf ("Software\\GSettings");
RegistryCacheItem *item = g_slice_new (RegistryCacheItem); item = g_slice_new (RegistryCacheItem);
item->value.type = REG_NONE; item->value.type = REG_NONE;
item->value.ptr = NULL; item->value.ptr = NULL;
item->name = g_strdup ("<root>"); item->name = g_strdup ("<root>");