luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-23 10:42:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

gopenuriportal: Fix a use-after-free on an error path

Browse Source 
`path` was used in building the error message after it had been freed.
Spotted by scan-build.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Helps: #1767
This commit is contained in:
Philip Withnall 2022-04-28 10:56:10 +01:00
parent d5386a5493
commit a31474e41d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gio/gopenuriportal.c
View File

@ -108,10 +108,10 @@ g_openuri_portal_open_uri (const char *uri,
errsv = errno; errsv = errno;
if (fd == -1) if (fd == -1)
{ {
g_free (path);
g_variant_builder_clear (&opt_builder);
g_set_error (error, G_IO_ERROR, g_io_error_from_errno (errsv), g_set_error (error, G_IO_ERROR, g_io_error_from_errno (errsv),
"Failed to open '%s'", path); "Failed to open '%s'", path);
g_free (path);
g_variant_builder_clear (&opt_builder);
return FALSE; return FALSE;
} }