luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-26 15:36:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

gkeyfilesettingsbackend: Disallow empty key or group names

Browse Source 
These should never have been allowed; they will result in precondition
failures from the `GKeyFile` later on in the code.

A test will be added for this shortly.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
This commit is contained in:
Philip Withnall 2021-02-10 21:19:30 +00:00
parent 9d27c57f70
commit a59247608f
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gio/gkeyfilesettingsbackend.c
View File

@ -161,6 +161,13 @@ convert_path (GKeyfileSettingsBackend *kfsb,
last_slash = strrchr (key, '/'); last_slash = strrchr (key, '/');
/* Disallow empty group names or key names */
if (key_len == 0 ||
(last_slash != NULL &&
(*(last_slash + 1) == '\0' ||
last_slash == key)))
return FALSE;
if (kfsb->root_group) if (kfsb->root_group)
{ {
/* if a root_group was specified, make sure the user hasn't given /* if a root_group was specified, make sure the user hasn't given