From a786a9a0204c66285f9686088512ddff67ac41fa Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Thu, 19 Apr 2001 21:48:21 +0000 Subject: [PATCH] We were returning junk memory here, because we didn't copy the value 2001-04-19 Havoc Pennington * gobject.c (g_object_get_valist): We were returning junk memory here, because we didn't copy the value (G_VALUE_NOCOPY_CONTENTS passed to G_VALUE_LCOPY) and then we freed the GValue immediately after. Removed G_VALUE_NOCOPY_CONTENTS from here; need a G_VALUE_STEAL_CONTENTS or the like if we want this optimization. --- gobject/ChangeLog | 8 ++++++++ gobject/gobject.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/gobject/ChangeLog b/gobject/ChangeLog index ad579b622..84dd1b512 100644 --- a/gobject/ChangeLog +++ b/gobject/ChangeLog @@ -1,3 +1,11 @@ +2001-04-19 Havoc Pennington + + * gobject.c (g_object_get_valist): We were returning junk memory + here, because we didn't copy the value (G_VALUE_NOCOPY_CONTENTS + passed to G_VALUE_LCOPY) and then we freed the GValue immediately + after. Removed G_VALUE_NOCOPY_CONTENTS from here; need a + G_VALUE_STEAL_CONTENTS or the like if we want this optimization. + Wed Apr 18 09:46:56 2001 Owen Taylor * gobject.c gsignal.c: Change C++ comments for FIXME's to diff --git a/gobject/gobject.c b/gobject/gobject.c index 7590c4cae..0ee30a6fe 100644 --- a/gobject/gobject.c +++ b/gobject/gobject.c @@ -983,7 +983,7 @@ g_object_get_valist (GObject *object, object_get_property (object, pspec, &value); - G_VALUE_LCOPY (&value, var_args, G_VALUE_NOCOPY_CONTENTS, &error); + G_VALUE_LCOPY (&value, var_args, 0, &error); if (error) { g_warning ("%s: %s", G_STRLOC, error);