From 3ae88886ac7057cd4ba5fc000d5442e7bc4f5edc Mon Sep 17 00:00:00 2001 From: Luca Bacci Date: Wed, 6 Mar 2024 17:33:12 +0100 Subject: [PATCH 1/2] glocalfileinfo: Do not set G_FILE_ATTRIBUTE_ID_STANDARD_IS_BACKUP twice --- gio/glocalfileinfo.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/gio/glocalfileinfo.c b/gio/glocalfileinfo.c index ec45e45d2..595725d3b 100644 --- a/gio/glocalfileinfo.c +++ b/gio/glocalfileinfo.c @@ -2026,8 +2026,6 @@ _g_local_file_info_get (const char *basename, if (statbuf.reparse_tag != 0) _g_file_info_set_attribute_uint32_by_id (info, G_FILE_ATTRIBUTE_ID_DOS_REPARSE_POINT_TAG, statbuf.reparse_tag); - - _g_file_info_set_attribute_boolean_by_id (info, G_FILE_ATTRIBUTE_ID_STANDARD_IS_BACKUP, FALSE); #endif symlink_target = NULL; From 2cf0ce39aa26bd80615e87b61382d87cfba356b9 Mon Sep 17 00:00:00 2001 From: Luca Bacci Date: Wed, 6 Mar 2024 18:25:15 +0100 Subject: [PATCH 2/2] glocalfileinfo: Use stat results only if stat succeeded --- gio/glocalfileinfo.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/gio/glocalfileinfo.c b/gio/glocalfileinfo.c index 595725d3b..8d7831fb7 100644 --- a/gio/glocalfileinfo.c +++ b/gio/glocalfileinfo.c @@ -2021,11 +2021,14 @@ _g_local_file_info_get (const char *basename, _g_file_info_set_attribute_boolean_by_id (info, G_FILE_ATTRIBUTE_ID_DOS_IS_SYSTEM, (statbuf.attributes & FILE_ATTRIBUTE_SYSTEM)); - _g_file_info_set_attribute_boolean_by_id (info, G_FILE_ATTRIBUTE_ID_DOS_IS_MOUNTPOINT, - (statbuf.reparse_tag == IO_REPARSE_TAG_MOUNT_POINT)); + if (stat_ok) + { + _g_file_info_set_attribute_boolean_by_id (info, G_FILE_ATTRIBUTE_ID_DOS_IS_MOUNTPOINT, + (statbuf.reparse_tag == IO_REPARSE_TAG_MOUNT_POINT)); - if (statbuf.reparse_tag != 0) - _g_file_info_set_attribute_uint32_by_id (info, G_FILE_ATTRIBUTE_ID_DOS_REPARSE_POINT_TAG, statbuf.reparse_tag); + if (statbuf.reparse_tag != 0) + _g_file_info_set_attribute_uint32_by_id (info, G_FILE_ATTRIBUTE_ID_DOS_REPARSE_POINT_TAG, statbuf.reparse_tag); + } #endif symlink_target = NULL;