luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-03 17:56:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "gstdio: Temporarily disable g_close() warning on macOS"

Browse Source 
This reverts commit 5190354ad9.

Now that g_close isn't called from gspawn anymore, we can reenable
the g_close warning on macOS.

Closes: #2785
This commit is contained in:
Ray Strode 2022-10-28 11:23:55 -04:00
parent 168fd4f2b3
commit aaae515e13
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
glib/gstdio.c
View File

@ -1816,13 +1816,7 @@ g_close (gint fd,
* not necessarily in the caller of g_close(), but somebody else
* might have wrongly closed fd. In any case, there is a serious bug
* somewhere. */
/* FIXME: This causes a number of unit test failures on macOS.
* Disabling the message for now until someone with access to a
* macOS machine can investigate.
* See https://gitlab.gnome.org/GNOME/glib/-/issues/2785 */
#ifndef G_OS_DARWIN
g_critical ("g_close(fd:%d) failed with EBADF. The tracking of file descriptors got messed up", fd);
#endif
}
else
{

2
glib/tests/spawn-test.c
View File

@ -225,7 +225,7 @@ test_spawn_stdio_overwrite (void)
char **envp = g_get_environ ();
enum OpenState { OPENED = 0, CLOSED = 1, DONE = 2 } stdin_state, stdout_state, stderr_state, output_return_state, error_return_state;
g_test_bug ("https://gitlab.gnome.org/GNOME/glib/-/issues/2055");
g_test_bug ("https://gitlab.gnome.org/GNOME/glib/-/issues/16");
old_stdin_fd = dup (STDIN_FILENO);
old_stdout_fd = dup (STDOUT_FILENO);