never dispatch sources of mixed priority, because while iterating over the

2002-02-13  Havoc Pennington  <hp@redhat.com>

	* glib/gmain.c (g_main_context_check): never dispatch sources of
	mixed priority, because while iterating over the dispatch array a
	new source with more priority may be added, while a source with
	less priority remains in the dispatch array

ChangeLog

@@ -1,3 +1,10 @@
+2002-02-13  Havoc Pennington  <hp@redhat.com>
+
+	* glib/gmain.c (g_main_context_check): never dispatch sources of
+	mixed priority, because while iterating over the dispatch array a
+	new source with more priority may be added, while a source with
+	less priority remains in the dispatch array
+
 2002-02-11  Darin Adler  <darin@bentspoon.com>
 
 	* glib/gmessages.h: Use "if (expr) { } else" as I meant to in the

ChangeLog.pre-2-0

@@ -1,3 +1,10 @@
+2002-02-13  Havoc Pennington  <hp@redhat.com>
+
+	* glib/gmain.c (g_main_context_check): never dispatch sources of
+	mixed priority, because while iterating over the dispatch array a
+	new source with more priority may be added, while a source with
+	less priority remains in the dispatch array
+
 2002-02-11  Darin Adler  <darin@bentspoon.com>
 
 	* glib/gmessages.h: Use "if (expr) { } else" as I meant to in the

ChangeLog.pre-2-10

@@ -1,3 +1,10 @@
+2002-02-13  Havoc Pennington  <hp@redhat.com>
+
+	* glib/gmain.c (g_main_context_check): never dispatch sources of
+	mixed priority, because while iterating over the dispatch array a
+	new source with more priority may be added, while a source with
+	less priority remains in the dispatch array
+
 2002-02-11  Darin Adler  <darin@bentspoon.com>
 
 	* glib/gmessages.h: Use "if (expr) { } else" as I meant to in the

ChangeLog.pre-2-12

@@ -1,3 +1,10 @@
+2002-02-13  Havoc Pennington  <hp@redhat.com>
+
+	* glib/gmain.c (g_main_context_check): never dispatch sources of
+	mixed priority, because while iterating over the dispatch array a
+	new source with more priority may be added, while a source with
+	less priority remains in the dispatch array
+
 2002-02-11  Darin Adler  <darin@bentspoon.com>
 
 	* glib/gmessages.h: Use "if (expr) { } else" as I meant to in the

ChangeLog.pre-2-2

@@ -1,3 +1,10 @@
+2002-02-13  Havoc Pennington  <hp@redhat.com>
+
+	* glib/gmain.c (g_main_context_check): never dispatch sources of
+	mixed priority, because while iterating over the dispatch array a
+	new source with more priority may be added, while a source with
+	less priority remains in the dispatch array
+
 2002-02-11  Darin Adler  <darin@bentspoon.com>
 
 	* glib/gmessages.h: Use "if (expr) { } else" as I meant to in the

ChangeLog.pre-2-4

@@ -1,3 +1,10 @@
+2002-02-13  Havoc Pennington  <hp@redhat.com>
+
+	* glib/gmain.c (g_main_context_check): never dispatch sources of
+	mixed priority, because while iterating over the dispatch array a
+	new source with more priority may be added, while a source with
+	less priority remains in the dispatch array
+
 2002-02-11  Darin Adler  <darin@bentspoon.com>
 
 	* glib/gmessages.h: Use "if (expr) { } else" as I meant to in the

ChangeLog.pre-2-6

@@ -1,3 +1,10 @@
+2002-02-13  Havoc Pennington  <hp@redhat.com>
+
+	* glib/gmain.c (g_main_context_check): never dispatch sources of
+	mixed priority, because while iterating over the dispatch array a
+	new source with more priority may be added, while a source with
+	less priority remains in the dispatch array
+
 2002-02-11  Darin Adler  <darin@bentspoon.com>
 
 	* glib/gmessages.h: Use "if (expr) { } else" as I meant to in the

ChangeLog.pre-2-8

@@ -1,3 +1,10 @@
+2002-02-13  Havoc Pennington  <hp@redhat.com>
+
+	* glib/gmain.c (g_main_context_check): never dispatch sources of
+	mixed priority, because while iterating over the dispatch array a
+	new source with more priority may be added, while a source with
+	less priority remains in the dispatch array
+
 2002-02-11  Darin Adler  <darin@bentspoon.com>
 
 	* glib/gmessages.h: Use "if (expr) { } else" as I meant to in the

glib/gmain.c

@@ -2128,6 +2128,11 @@ g_main_context_check (GMainContext *context,
 	  g_ptr_array_add (context->pending_dispatches, source);
 
 	  n_ready++;
+
+          /* never dispatch sources with less priority than the first
+           * one we choose to dispatch
+           */
+          max_priority = source->priority;
 	}
 
     next: