luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-14 05:16:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

GDBusProxy: on_properties_changed initialize some variables

Browse Source 
This avoids calling g_variant_unref and g_free on uninitialized memory
if PropertiesChanged is received in the creating thread's thread-default
main context's thread, at the same time as releasing the last ref in
another thread. This would result in "goto out" before the variables
freed after that label had been initialized to NULL.

Based on a patch by Simon McVittie, bug 656282
This commit is contained in:
Matthias Clasen 2011-08-13 16:09:41 -04:00
parent 655299a057
commit ae496a52a9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gio/gdbusproxy.c
View File

@ -928,6 +928,9 @@ on_properties_changed (GDBusConnection *connection,
GVariant *value; GVariant *value;
guint n; guint n;
changed_properties = NULL;
invalidated_properties = NULL;
G_LOCK (signal_subscription_lock); G_LOCK (signal_subscription_lock);
proxy = data->proxy; proxy = data->proxy;
if (proxy == NULL) if (proxy == NULL)
@ -941,9 +944,6 @@ on_properties_changed (GDBusConnection *connection,
G_UNLOCK (signal_subscription_lock); G_UNLOCK (signal_subscription_lock);
} }
changed_properties = NULL;
invalidated_properties = NULL;
if (!proxy->priv->initialized) if (!proxy->priv->initialized)
goto out; goto out;