luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-10 03:16:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Replace a g_slist_prepend/g_slist_remove pair with an on-stack link and

Browse Source 
2007-03-15  Chris Wilson  <chris@chris-wilson.co.uk>

	* glib/gmain.c (g_main_dispatch): Replace a
	g_slist_prepend/g_slist_remove pair with an on-stack link
	and open coding. (#416094)


svn path=/trunk/; revision=5407
This commit is contained in:
Chris Wilson 2007-03-15 08:47:28 +00:00 committed by Chris Wilson
parent 617862f3f0
commit af8671792d
2 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
2007-03-15 Chris Wilson <chris@chris-wilson.co.uk>
* glib/gmain.c (g_main_dispatch): Replace a
g_slist_prepend/g_slist_remove pair with an on-stack link
and open coding. (#416094)
2007-03-15 Matthias Clasen <mclasen@redhat.com> 2007-03-15 Matthias Clasen <mclasen@redhat.com>
* glib/gscanner.[hc]: Some optimizations, use a lookup * glib/gscanner.[hc]: Some optimizations, use a lookup

17
glib/gmain.c
View File

@ -2025,6 +2025,7 @@ g_main_dispatch (GMainContext *context)
gboolean (*dispatch) (GSource *, gboolean (*dispatch) (GSource *,
GSourceFunc, GSourceFunc,
gpointer); gpointer);
GSList current_source_link;
dispatch = source->source_funcs->dispatch; dispatch = source->source_funcs->dispatch;
cb_funcs = source->callback_funcs; cb_funcs = source->callback_funcs;
@ -2045,11 +2046,23 @@ g_main_dispatch (GMainContext *context)
UNLOCK_CONTEXT (context); UNLOCK_CONTEXT (context);
current->depth++; current->depth++;
current->source = g_slist_prepend (current->source, source); /* The on-stack allocation of the GSList is unconventional, but
* we know that the lifetime of the link is bounded to this
* function as the link is kept in a thread specific list and
* not manipulated outside of this function and its descendants.
* Avoiding the overhead of a g_slist_alloc() is useful as many
* applications do little more than dispatch events.
*
* This is a performance hack - do not revert to g_slist_prepend()!
*/
current_source_link.data = source;
current_source_link.next = current->source;
current->source = &current_source_link;
need_destroy = ! dispatch (source, need_destroy = ! dispatch (source,
callback, callback,
user_data); user_data);
current->source = g_slist_remove (current->source, source); g_assert (current->source == &current_source_link);
current->source = current_source_link.next;
current->depth--; current->depth--;
if (cb_funcs) if (cb_funcs)