From b0c7221c559693baf0735d6562940e0eec0a798c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Wilmet?= Date: Thu, 3 Jul 2014 15:45:11 +0200 Subject: [PATCH] doc: improve doc of g_subprocess_wait() When using this API, I wasn't sure what the cancellable does. I think it's generally desirable to kill the subprocess if the wait operation is cancelled, since in this case the application is no longer interested by the subprocess. https://bugzilla.gnome.org/show_bug.cgi?id=732704 --- gio/gsubprocess.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gio/gsubprocess.c b/gio/gsubprocess.c index 339b54b95..999d777e4 100644 --- a/gio/gsubprocess.c +++ b/gio/gsubprocess.c @@ -941,6 +941,9 @@ g_subprocess_sync_complete (GAsyncResult **result) * This function does not fail in the case of the subprocess having * abnormal termination. See g_subprocess_wait_check() for that. * + * Cancelling @cancellable doesn't kill the subprocess. Call + * g_subprocess_force_exit() if it is desirable. + * * Returns: %TRUE on success, %FALSE if @cancellable was cancelled * * Since: 2.40