luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-10-31 00:12:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

glib/tests/unix: Free fds before exiting

Browse Source 
Old valgrind wasn't spotting this but we're smarter now!
This commit is contained in:
Marco Trevisan (Treviño)
2024-05-24 19:10:08 +02:00
parent 64f7445232
commit b2c5092bf1
1 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
glib/tests/unix.c
View File

@@ -103,14 +103,18 @@ test_closefrom (void)
if (flags == -1) if (flags == -1)
{ {
int exit_code = 100 + fds[i];
async_signal_safe_message ("fd should not have been closed"); async_signal_safe_message ("fd should not have been closed");
_exit (100 + fds[i]); g_free (fds);
_exit (exit_code);
} }
if (flags & FD_CLOEXEC) if (flags & FD_CLOEXEC)
{ {
int exit_code = 100 + fds[i];
async_signal_safe_message ("fd should not have been close-on-exec yet"); async_signal_safe_message ("fd should not have been close-on-exec yet");
_exit (100 + fds[i]); g_free (fds);
_exit (exit_code);
} }
} }
@@ -122,14 +126,18 @@ test_closefrom (void)
if (flags == -1) if (flags == -1)
{ {
int exit_code = 100 + fds[i];
async_signal_safe_message ("fd should not have been closed"); async_signal_safe_message ("fd should not have been closed");
_exit (100 + fds[i]); g_free (fds);
_exit (exit_code);
} }
if (!(flags & FD_CLOEXEC)) if (!(flags & FD_CLOEXEC))
{ {
int exit_code = 100 + fds[i];
async_signal_safe_message ("fd should have been close-on-exec"); async_signal_safe_message ("fd should have been close-on-exec");
_exit (100 + fds[i]); g_free (fds);
_exit (exit_code);
} }
} }
@@ -142,12 +150,14 @@ test_closefrom (void)
if (flags == -1) if (flags == -1)
{ {
async_signal_safe_message ("fd should not have been closed"); async_signal_safe_message ("fd should not have been closed");
g_free (fds);
_exit (100 + fd); _exit (100 + fd);
} }
if (flags & FD_CLOEXEC) if (flags & FD_CLOEXEC)
{ {
async_signal_safe_message ("fd should not have been close-on-exec"); async_signal_safe_message ("fd should not have been close-on-exec");
g_free (fds);
_exit (100 + fd); _exit (100 + fd);
} }
} }
@@ -157,10 +167,12 @@ test_closefrom (void)
if (fcntl (fds[i], F_GETFD) != -1 || errno != EBADF) if (fcntl (fds[i], F_GETFD) != -1 || errno != EBADF)
{ {
async_signal_safe_message ("fd should have been closed"); async_signal_safe_message ("fd should have been closed");
g_free (fds);
_exit (100 + fds[i]); _exit (100 + fds[i]);
} }
} }
g_free (fds);
_exit (0); _exit (0);
} }