luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-27 07:56:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

tests: Fix incomplete failure check in socket test

Browse Source 
For the check "if (error != NULL)" to work as expected, the
create_server() (and create_server_full()) functions need to make
sure to return an error for all the possible failures, but this
might not always be the case.

Catch all the failures by testing for a non-NULL return value if there
was no error.
This commit is contained in:
Bastien Nocera 2019-12-02 17:34:03 +01:00 committed by Philip Withnall
parent 027c3f8d59
commit b3197f2740
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gio/tests/socket.c
View File

@ -342,6 +342,7 @@ test_ip_async (GSocketFamily family)
g_clear_error (&error); g_clear_error (&error);
return; return;
} }
g_assert_nonnull (data);
addr = g_socket_get_local_address (data->server, &error); addr = g_socket_get_local_address (data->server, &error);
g_assert_no_error (error); g_assert_no_error (error);