luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-09-28 18:16:34 +02:00
Code Issues Packages Projects Releases Wiki Activity

g_strcompress: check that source is non-NULL rather than just crashing

Browse Source 
Calling this function with a NULL argument is considered to be invalid,
but one of the regression tests does it anyway (to watch it crash), which
seems a good indication that it's expected to be somewhat common.
Let's check it rather than segfaulting.

Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Emmanuele Bassi <ebassi@linux.intel.com>
Reviewed-by: Matthias Clasen <mclasen@redhat.com>
This commit is contained in:
Simon McVittie
2011-12-12 18:37:10 +00:00
parent f65c741db4
commit b39798267d
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
glib/gstrfuncs.c
View File

@@ -2209,8 +2209,13 @@ gchar*
g_strcompress (const gchar *source) g_strcompress (const gchar *source)
{ {
const gchar *p = source, *octal; const gchar *p = source, *octal;
gchar *dest = g_malloc (strlen (source) + 1); gchar *dest;
gchar *q = dest; gchar *q;
g_return_val_if_fail (source != NULL, NULL);
dest = g_malloc (strlen (source) + 1);
q = dest;
while (*p) while (*p)
{ {