luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-09-27 17:52:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'use-gobject-hole' into 'master'

Browse Source 
Use the GObject hole on 64bit arches for some flags to improve performance

See merge request GNOME/glib!1083
This commit is contained in:
Philip Withnall
2019-11-07 08:15:03 +00:00
parent cc1b53f74e 5afd574e91
commit b43bfcaa68
3 changed files with 128 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
gobject/gsignal.c
View File

@@ -711,7 +711,7 @@ handler_insert (guint signal_id,
HandlerList *hlist;
g_assert (handler->prev == NULL && handler->next == NULL); /* paranoid */
hlist = handler_list_ensure (signal_id, instance);
if (!hlist->handlers)
{
@@ -2349,7 +2349,10 @@ g_signal_connect_closure_by_id (gpointer instance,
else
{
Handler *handler = handler_new (signal_id, instance, after);
if (G_TYPE_IS_OBJECT (node->itype))
_g_object_set_has_signal_handler ((GObject *)instance);
handler_seq_no = handler->sequential_number;
handler->detail = detail;
handler->closure = g_closure_ref (closure);
@@ -2414,6 +2417,9 @@ g_signal_connect_closure (gpointer instance,
{
Handler *handler = handler_new (signal_id, instance, after);
if (G_TYPE_IS_OBJECT (node->itype))
_g_object_set_has_signal_handler ((GObject *)instance);
handler_seq_no = handler->sequential_number;
handler->detail = detail;
handler->closure = g_closure_ref (closure);
@@ -2515,6 +2521,9 @@ g_signal_connect_data (gpointer instance,
{
Handler *handler = handler_new (signal_id, instance, after);
if (G_TYPE_IS_OBJECT (node->itype))
_g_object_set_has_signal_handler ((GObject *)instance);
handler_seq_no = handler->sequential_number;
handler->detail = detail;
handler->closure = g_closure_ref ((swapped ? g_cclosure_new_swap : g_cclosure_new) (c_handler, data, destroy_data));
@@ -3125,7 +3134,14 @@ g_signal_emitv (const GValue *instance_and_params,
(node->single_va_closure == SINGLE_VA_CLOSURE_EMPTY_MAGIC ||
_g_closure_is_void (node->single_va_closure, instance)))
{
HandlerList* hlist = handler_list_lookup (node->signal_id, instance);
HandlerList* hlist;
/* single_va_closure is only true for GObjects, so fast path if no handler ever connected to the signal */
if (_g_object_has_signal_handler ((GObject *)instance))
hlist = handler_list_lookup (node->signal_id, instance);
else
hlist = NULL;
if (hlist == NULL || hlist->handlers == NULL)
{
/* nothing to do to emit this signal */
@@ -3208,7 +3224,7 @@ g_signal_emit_valist (gpointer instance,
if (node->single_va_closure != NULL)
{
HandlerList* hlist = handler_list_lookup (node->signal_id, instance);
HandlerList* hlist;
Handler *fastpath_handler = NULL;
Handler *l;
GClosure *closure = NULL;
@@ -3230,6 +3246,12 @@ g_signal_emit_valist (gpointer instance,
fastpath = FALSE;
}
/* single_va_closure is only true for GObjects, so fast path if no handler ever connected to the signal */
if (_g_object_has_signal_handler ((GObject *)instance))
hlist = handler_list_lookup (node->signal_id, instance);
else
hlist = NULL;
for (l = hlist ? hlist->handlers : NULL; fastpath && l != NULL; l = l->next)
{
if (!l->block_count &&