luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-08-20 07:38:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

gdesktopappinfo: Return failure rather than blindly call xterm

Browse Source 
Instead of calling xterm when it clearly does not exist and causes a silent error,
inform the user that the launch failed so they can take the right action.
This commit is contained in:
shironeko
2021-09-09 10:32:44 -04:00
parent 9f102c22d4
commit b60cd327fe
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gio/gdesktopappinfo.c
View File

@@ -2612,10 +2612,13 @@ prepend_terminal_to_vector (int *argc,
check = g_find_program_in_path ("rxvt"); check = g_find_program_in_path ("rxvt");
if (check == NULL) if (check == NULL)
check = g_find_program_in_path ("dtterm"); check = g_find_program_in_path ("dtterm");
if (check == NULL)
check = g_find_program_in_path ("xterm");
if (check == NULL) if (check == NULL)
{ {
check = g_strdup ("xterm"); g_debug ("Couldn’t find a known terminal");
g_debug ("Couldn’t find a terminal: falling back to xterm"); g_free (term_argv);
return FALSE;
} }
term_argv[0] = check; term_argv[0] = check;
term_argv[1] = g_strdup ("-e"); term_argv[1] = g_strdup ("-e");