luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-10-31 08:22:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

tests: Improve error handling for fileutils test

Browse Source 
The test_stdio_wrappers() test will spuriously fail if the mkdir-test
directory already exists and is non-empty, which can happen if a
previous test run has failed and left a coredump file in the directory.
Tighten up the error checking around the pre-test rmdir() call to catch
this failure.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

https://bugzilla.gnome.org/show_bug.cgi?id=782237
This commit is contained in:
Philip Withnall
2017-05-08 11:19:46 +01:00
parent 5c1e85669a
commit b7ffc07d98
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
glib/tests/fileutils.c
View File

@@ -848,7 +848,8 @@ test_stdio_wrappers (void)
GError *error = NULL; GError *error = NULL;
g_remove ("mkdir-test/test-create"); g_remove ("mkdir-test/test-create");
g_rmdir ("mkdir-test"); ret = g_rmdir ("mkdir-test");
g_assert (ret == 0 || errno == ENOENT);
ret = g_stat ("mkdir-test", &buf); ret = g_stat ("mkdir-test", &buf);
g_assert_cmpint (ret, ==, -1); g_assert_cmpint (ret, ==, -1);